Resolve "“Add from Publication” modal on dance list editing page doesn't work." #75

Merged

anselm merged 6 commits from 45-add-from-publication-modal-on-dance-list-editing-page-doesn-t-work into main

2023-07-03 08:04:17 +02:00

anselm commented

2023-07-03 01:32:54 +02:00

(Migrated from gitlab.anselms.net)

This MR introduces the following changes:

“Tom Select” autocomplete widgets are properly initialised on dynamically-loaded modals.
The extra-info line in the autocompletion popup is set to something meaningful (the publisher in case of “Add from Publication …”,
the list owner in case of “Add from Other List …”).
Autocompletion proposals for “Add from Other List …” not only include the current user's own lists but also group-owned lists
that are accessible to them.
SSE reread notifications are sent correctly.

Closes #45.

This MR introduces the following changes: - “Tom Select” autocomplete widgets are properly initialised on dynamically-loaded modals. - The extra-info line in the autocompletion popup is set to something meaningful (the publisher in case of “Add from Publication …”, the list owner in case of “Add from Other List …”). - Autocompletion proposals for “Add from Other List …” not only include the current user's own lists but also group-owned lists that are accessible to them. - SSE reread notifications are sent correctly. Closes #45.

anselm commented

2023-07-03 01:32:54 +02:00

(Migrated from gitlab.anselms.net)

assigned to @anselm

anselm commented

2023-07-03 02:01:53 +02:00

(Migrated from gitlab.anselms.net)

added 6 commits

51a123b0 - fix: Ensure that “Tom Select” widgets are initialised on modal load.
001de385 - refactor: Adapt formatting of publication auto-completion results.
e1a45f75 - feature: Change `DanceList.get_visible()` to make public lists optional.
1f43f1bd - refactor: Improve dance list autocompletion results.
a3e28cf8 - fix: Make sure the correct table is re-read after “Add from Publication …”.
f6275bc7 - fix: Include “Alternative” dances when copying a dance list from another.

Compare with previous version

added 6 commits <ul><li>51a123b0 - fix: Ensure that “Tom Select” widgets are initialised on modal load.</li><li>001de385 - refactor: Adapt formatting of publication auto-completion results.</li><li>e1a45f75 - feature: Change `DanceList.get_visible()` to make public lists optional.</li><li>1f43f1bd - refactor: Improve dance list autocompletion results.</li><li>a3e28cf8 - fix: Make sure the correct table is re-read after “Add from Publication …”.</li><li>f6275bc7 - fix: Include “Alternative” dances when copying a dance list from another.</li></ul> [Compare with previous version](/strathspey/ace4/-/merge_requests/19/diffs?diff_id=156&start_sha=be15c19d3eb53b2d05fd5646f6ba5b31c9f4ae52)

anselm commented

2023-07-03 02:02:14 +02:00

(Migrated from gitlab.anselms.net)

marked this merge request as ready

marked this merge request as **ready**

anselm commented

2023-07-03 02:03:48 +02:00

(Migrated from gitlab.anselms.net)

changed the description

anselm commented

2023-07-03 08:04:17 +02:00

(Migrated from gitlab.anselms.net)