Strathspey/ace4
1
0
Fork 0
Code Issues 28 Pull requests Projects Releases Packages Wiki Activity Actions

Resolve "Dance Lists: note non-display" #68

Merged
anselm merged 2 commits from 25-dance-lists-note-non-display into main 2023-06-01 01:04:00 +02:00
Conversation 8 Commits 2 Files changed 1 +22
anselm commented 2023-05-31 22:54:04 +02:00 (Migrated from gitlab.anselms.net)
Copy link

We will roughly need to do the following:

  • Ensure that if a list that is opened for editing has show_item_notes set, the notes will be displayed (without the user having
    to re-enable the setting).
  • Ensure that saving changes to dance list metadata (from the “Edit List Settings …” dialog) causes lists to be re-read everywhere.
  • Ensure that saving a list note will cause that item to be re-read everywhere (this is probably already the case).
  • (EXTRA CREDIT) When opening a list that has item notes but its show_item_notes is unset, display a warning banner (ideally with
    a button that will set show_item_notes.

Closes #25

We will roughly need to do the following: - [x] Ensure that if a list that is opened for editing has `show_item_notes` set, the notes will be displayed (without the user having to re-enable the setting). - [x] Ensure that saving changes to dance list metadata (from the “Edit List Settings …” dialog) causes lists to be re-read everywhere. - [x] Ensure that saving a list note will cause that item to be re-read everywhere (this is probably already the case). - [x] (EXTRA CREDIT) When opening a list that has item notes but its `show_item_notes` is unset, display a warning banner (ideally with a button that will set `show_item_notes`. Closes #25
anselm commented 2023-05-31 22:54:04 +02:00 (Migrated from gitlab.anselms.net)
Copy link

assigned to @anselm

assigned to @anselm
anselm commented 2023-06-01 00:38:32 +02:00 (Migrated from gitlab.anselms.net)
Copy link

marked the checklist item Ensure that if a list that is opened for editing has show_item_notes set, the notes will be displayed (without the user having as completed

marked the checklist item **Ensure that if a list that is opened for editing has `show_item_notes` set, the notes will be displayed (without the user having** as completed
anselm commented 2023-06-01 00:38:35 +02:00 (Migrated from gitlab.anselms.net)
Copy link

marked the checklist item Ensure that saving changes to dance list metadata (from the “Edit List Settings …” dialog) causes lists to be re-read everywhere. as completed

marked the checklist item **Ensure that saving changes to dance list metadata (from the “Edit List Settings …” dialog) causes lists to be re-read everywhere.** as completed
anselm commented 2023-06-01 00:40:10 +02:00 (Migrated from gitlab.anselms.net)
Copy link

marked the checklist item Ensure that saving a list note will cause that item to be re-read everywhere (this is probably already the case). as completed

marked the checklist item **Ensure that saving a list note will cause that item to be re-read everywhere (this is probably already the case).** as completed
anselm commented 2023-06-01 01:02:48 +02:00 (Migrated from gitlab.anselms.net)
Copy link

added 2 commits

  • 40bd7add - fix: Ensure lists are reread after the list settings have changed.
  • c7ce539c - feature: Show warning if a dance list has notes but notes display is off.

Compare with previous version

added 2 commits <ul><li>40bd7add - fix: Ensure lists are reread after the list settings have changed.</li><li>c7ce539c - feature: Show warning if a dance list has notes but notes display is off.</li></ul> [Compare with previous version](/strathspey/ace4/-/merge_requests/12/diffs?diff_id=135&start_sha=f8674386441f15c28967dbf29827d62f429ef3c1)
anselm commented 2023-06-01 01:03:42 +02:00 (Migrated from gitlab.anselms.net)
Copy link

marked the checklist item (EXTRA CREDIT) When opening a list that has item notes but its show_item_notes is unset, display a warning banner (ideally with as completed

marked the checklist item **(EXTRA CREDIT) When opening a list that has item notes but its `show_item_notes` is unset, display a warning banner (ideally with** as completed
anselm commented 2023-06-01 01:03:54 +02:00 (Migrated from gitlab.anselms.net)
Copy link

marked this merge request as ready

marked this merge request as **ready**
anselm commented 2023-06-01 01:04:00 +02:00 (Migrated from gitlab.anselms.net)
Copy link

mentioned in commit ee7fc28fbe

mentioned in commit ee7fc28fbef39c1623ecb575f2123aebb836854b
anselm (Migrated from gitlab.anselms.net) merged commit ee7fc28fbe into main 2023-06-01 01:04:00 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
ACE3

   
ASAP

Handle as soon as possible

  
Admin

   
Some Time

Handle when the time is right

  
Soon(ish)

Handle when you get around to it

  
accepted

   
bug

A defect in the program that should be fixed

  
collections

   
dance-lists

   
discussion

   
duplicate

   
easy

A simple thing that shouldn't take very long

  
enhancement

A shortcoming or interesting feature idea that deserves consideration

  
fixed

   
ignored

   
schema-change

Needs a (visible) database schema change to be implemented

  
wont-fix
No labels
ACE3
ASAP
Admin
Some Time
Soon(ish)
accepted
bug
collections
dance-lists
discussion
duplicate
easy
enhancement
fixed
ignored
schema-change
wont-fix
Milestone
Clear milestone
No items
No milestone
Dance List Rollup
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
Strathspey/ace4!68
No description provided.