DanceList.get_visible() needs `.distinct()` in query #43

New issue

Closed

opened 2023-06-27 00:04:33 +02:00 by anselm · 4 comments

anselm commented

2023-06-27 00:04:33 +02:00

(Migrated from gitlab.anselms.net)

In some situations, DanceList.get_visible() can return the same dance list several times. This leads to issues if the queryset is the base of a .get() call (e.g., for the dance list detail pages).

Sentry Issue: STRATHSPEY-V

DanceList.MultipleObjectsReturned: get() returned more than one DanceList -- it returned 2!
(2 additional frame(s) were not displayed)
...
  File "django/views/generic/base.py", line 104, in view
    return self.dispatch(request, *args, **kwargs)
  File "django/views/generic/base.py", line 143, in dispatch
    return handler(request, *args, **kwargs)
  File "django/views/generic/detail.py", line 108, in get
    self.object = self.get_object()
  File "django/views/generic/detail.py", line 53, in get_object
    obj = queryset.get()
  File "django/db/models/query.py", line 640, in get
    raise self.model.MultipleObjectsReturned(

In some situations, `DanceList.get_visible()` can return the same dance list several times. This leads to issues if the queryset is the base of a `.get()` call (e.g., for the dance list detail pages). Sentry Issue: [STRATHSPEY-V](https://sentry.strathspey.org/organizations/strathspey/issues/30/?referrer=gitlab_integration) ``` DanceList.MultipleObjectsReturned: get() returned more than one DanceList -- it returned 2! (2 additional frame(s) were not displayed) ... File "django/views/generic/base.py", line 104, in view return self.dispatch(request, *args, **kwargs) File "django/views/generic/base.py", line 143, in dispatch return handler(request, *args, **kwargs) File "django/views/generic/detail.py", line 108, in get self.object = self.get_object() File "django/views/generic/detail.py", line 53, in get_object obj = queryset.get() File "django/db/models/query.py", line 640, in get raise self.model.MultipleObjectsReturned( ```

anselm commented

2023-06-27 00:04:50 +02:00

(Migrated from gitlab.anselms.net)

assigned to @anselm

anselm commented

2023-07-02 00:14:52 +02:00

(Migrated from gitlab.anselms.net)

created branch 43-dancelist-get_visible-needs-distinct-in-query to address this issue

created branch [`43-dancelist-get_visible-needs-distinct-in-query`](/strathspey/ace4/-/compare/main...43-dancelist-get_visible-needs-distinct-in-query) to address this issue

anselm commented

2023-07-02 00:15:09 +02:00

(Migrated from gitlab.anselms.net)

mentioned in merge request !18