Strathspey/ace4
1
0
Fork 0
Code Issues 28 Pull requests Projects Releases Packages Wiki Activity Actions

Set “Reply-To” in diagram comment notification mails. #40

New issue
Closed
opened 2023-06-23 02:28:05 +02:00 by anselm · 3 comments
anselm commented 2023-06-23 02:28:05 +02:00 (Migrated from gitlab.anselms.net)
Copy link

Currently, diagram comment notification mails are sent with From: admin@strathspey.org. This is a problem because whoever answers them will hit “Reply”, and then the answer will go to me instead of who ever originally submitted the comment.

Obviously we can't forge e-mails from the original sender (From: original-sender@wherever.net) because that will cause problems with things like SPF. Therefore we should add Reply-To: original-sender@wherever.net to these messages. That way at least if the message still goes to admin@strathspey.org, it's the fault of whatever crappy e-mail software the diagram person is using.

(The same applies to crib comment notification mails.)

Currently, diagram comment notification mails are sent with `From: admin@strathspey.org`. This is a problem because whoever answers them will hit “Reply”, and then the answer will go to me instead of who ever originally submitted the comment. Obviously we can't forge e-mails from the original sender (`From: original-sender@wherever.net`) because that will cause problems with things like SPF. Therefore we should add `Reply-To: original-sender@wherever.net` to these messages. That way at least if the message still goes to `admin@strathspey.org`, it's the fault of whatever crappy e-mail software the diagram person is using. (The same applies to crib comment notification mails.)
anselm commented 2023-06-24 01:32:07 +02:00 (Migrated from gitlab.anselms.net)
Copy link

created branch 40-set-reply-to-in-diagram-comment-notification-mails to address this issue

created branch [`40-set-reply-to-in-diagram-comment-notification-mails`](/strathspey/ace4/-/compare/main...40-set-reply-to-in-diagram-comment-notification-mails) to address this issue
anselm commented 2023-06-24 01:34:23 +02:00 (Migrated from gitlab.anselms.net)
Copy link

mentioned in merge request !14

mentioned in merge request !14
anselm commented 2023-06-24 01:45:58 +02:00 (Migrated from gitlab.anselms.net)
Copy link

mentioned in commit b7b7b3d0c2

mentioned in commit b7b7b3d0c215466dbf3986711cd0c491e2fd0f2d
anselm (Migrated from gitlab.anselms.net) closed this issue 2023-06-24 01:45:59 +02:00
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
main
set-secret-detection-config-1
feature/list-edit-sse
25.318.1
25.316.3
25.316.2
25.316.1
25.298.1
25.281.1
25.260.1
25.254.1
25.250.3
25.250.2
25.250.1
25.249.1
25.244.2
25.244.1
25.237.1
25.236.2
25.236.1
25.231.1
25.223.2
25.223.1
25.222.3
25.222.2
25.222.1
25.215.2
25.215.1
25.209.1
25.208.1
25.207.3
25.207.2
25.207.1
25.206.1
25.203.2
25.203.1
25.201.3
25.201.2
25.201.1
25.200.1
25.198.2
25.198.1
25.197.4
25.197.3
25.197.2
25.197.1
25.196.3
25.196.2
25.196.1
25.195.1
25.181.1
25.171.1
25.170.1
25.139.3
25.139.2
25.139.1
25.138.1
25.137.1
25.62.4
25.62.3
25.62.2
25.62.1
25.61.1
25.58.2
25.58.1
25.56.3
25.56.2
25.56.1
25.55.1
25.54.1
25.53.1
25.46.1
25.42.1
25.40.2
25.40.1
25.39.1
25.32.1
25.11.2
25.11.1
25.8.1
25.7.1
25.6.1
25.5.1
24.366.5
24.366.4
24.366.3
24.366.2
24.366.1
24.363.1
24.351.1
24.327.1
24.310.1
24.306.2
24.306.1
24.297.1
24.263.1
24.259.1
24.225.1
24.176.2
24.176.1
24.172.1
24.98.5
24.98.4
24.98.3
24.98.2
24.98.1
24.74.2
24.74.1
24.46.1
24.9.1
23.350.2
23.350.1
23.348.1
23.341.1
23.339.2
23.339.1
23.338.1
23.336.1
23.333.1
23.330.1
23.275.1
23.268.3
23.268.2
23.268.1
23.262.1
23.250.1
23.248.1
23.246.3
23.246.2
23.246.1
23.243.1
23.242.1
23.240.1
23.239.2
23.239.1
23.238.1
23.236.2
23.236.1
23.234.2
23.234.1
23.232.2
23.232.1
23.230.1
23.228.1
23.227.2
23.227.1
23.226.3
23.226.2
23.226.1
23.244.2
23.224.1
23.219.5
23.219.4
23.219.3
23.219.2
23.219.1
23.218.3
23.218.2
23.218.1
23.217.1
23.216.1
23.215.1
23.214.1
23.213.3
23.213.2
23.213.1
23.212.1
23.211.2
23.211.1
23.210.1
23.208.1
23.207.2
23.207.1
23.206.3
23.206.2
23.206.1
23.198.1
23.196.3
23.196.2
23.196.1
23.194.1
23.188.2
23.188.1
23.184.2
23.184.1
23.183.2
23.183.1
23.182.1
23.176.2
23.176.1
23.175.1
23.174.1
23.172.1
23.163.1
23.159.2
23.159.1
23.157.3
23.157.2
23.157.1
23.153.2
23.153.1
23.151.2
23.151.1
23.150.5
23.150.4
23.150.3
23.150.2
23.150.1
23.148.1
23.143.4
23.143.3
23.143.2
23.143.1
23.142.1
23.137.5
23.137.4
23.137.3
23.137.2
23.137.1
23.136.1
23.135.2
23.135.1
23.133.2
23.133.1
23.132.2
23.132.1
23.131.3
23.131.2
23.131.1
23.130.2
23.130.1
23.129.5
23.129.4
23.129.3
23.129.2
23.129.1
23.128.3
23.128.2
23.128.1
23.126.1
23.123.2
23.123.1
Labels
Clear labels   
ACE3

   
ASAP

Handle as soon as possible

  
Admin

   
Some Time

Handle when the time is right

  
Soon(ish)

Handle when you get around to it

  
accepted

   
bug

A defect in the program that should be fixed

  
collections

   
dance-lists

   
discussion

   
duplicate

   
easy

A simple thing that shouldn't take very long

  
enhancement

A shortcoming or interesting feature idea that deserves consideration

  
fixed

   
ignored

   
schema-change

Needs a (visible) database schema change to be implemented

  
wont-fix
No labels
ACE3
ASAP
Admin
Some Time
Soon(ish)
accepted
bug
collections
dance-lists
discussion
duplicate
easy
enhancement
fixed
ignored
schema-change
wont-fix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
Strathspey/ace4#40
No description provided.