Directory index rendering fails for non-admins. #33

New issue

Closed

opened 2023-05-02 00:58:39 +02:00 by anselm · 4 comments

anselm commented

2023-05-02 00:58:39 +02:00

(Migrated from gitlab.anselms.net)

Sentry Issue: ACE4-26

AttributeError: 'map' object has no attribute 'filter'
  File "ace4/cms/views.py", line 201, in dispatch
    return render_fileobject(request, path, obj, recurse, size_spec)
  File "ace4/cms/views.py", line 558, in render_fileobject
    content = dir_styles[style](request, path, obj)
  File "ace4/cms/views.py", line 366, in render_directory_index
    entries = entries.filter(status=S_PUBLISHED)

The problem here is that the .filter(status=S_PUBLISHED) is applied to something that isn't a queryset anymore. We have to move the check a few lines up so we can still do it on a queryset.

Sentry Issue: [ACE4-26](https://sentry.strathspey.org/organizations/strathspey/issues/157/?referrer=gitlab_integration) ``` AttributeError: 'map' object has no attribute 'filter' File "ace4/cms/views.py", line 201, in dispatch return render_fileobject(request, path, obj, recurse, size_spec) File "ace4/cms/views.py", line 558, in render_fileobject content = dir_styles[style](request, path, obj) File "ace4/cms/views.py", line 366, in render_directory_index entries = entries.filter(status=S_PUBLISHED) ``` The problem here is that the `.filter(status=S_PUBLISHED)` is applied to something that isn't a queryset anymore. We have to move the check a few lines up so we can still do it on a queryset.

anselm commented

2023-05-02 01:02:14 +02:00

(Migrated from gitlab.anselms.net)

changed the description

anselm commented

2023-05-02 01:02:31 +02:00

(Migrated from gitlab.anselms.net)

created branch 33-directory-index-rendering-fails-for-non-admins to address this issue

created branch [`33-directory-index-rendering-fails-for-non-admins`](/strathspey/ace4/-/compare/main...33-directory-index-rendering-fails-for-non-admins) to address this issue

anselm commented

2023-05-02 01:03:08 +02:00

(Migrated from gitlab.anselms.net)

mentioned in merge request !6